Fixed race starting and joining TSBPD thread #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
ethouris
approved these changes
Oct 29, 2020
maxsharabayko
force-pushed
the
hotfix/recv-data-lock
branch
from
d033aa3
to
32f390e
Compare
m_RecvDataCond must be used with m_RecvLock instead of m_RecvDataLock. m_RecvDataLock is only used to sync releaseSynch() calls.
…join. Deleted m_RecvDataLock. Fixes Haivision#1624
maxsharabayko
force-pushed
the
hotfix/recv-data-lock
branch
from
32f390e
to
f312e9d
Compare
|
Changes are split into two commits to simplify finding the faulty change in case of some issues. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of #1620. Fixes #1624.
Closes #1606. Closes #1620.
CUDT::m_RecvDataLockis removed, as it was wrongfully used together withCUDT::m_RecvDataCondin some places.CUDT::m_RecvDataCondis assumed to be used withCUDT::m_RecvLock.Added
CUDT::m_RcvTsbPdStartupLockto prevent a race in creating and joining the TSBPD thread from different threads.Reusing any of the existing mutexes complicates the code, unfortunately.