-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fixed a bug that responded a repeated conclusion HS with rejection #1650
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both case 1 and case 2 of #1648 resolved by thes changes, or only case 1?
Tested with case 1 only. I think case 2 is not covered because if a caller is "not convinced to be connected" and therefore still sends HS packets, it won't get any answer because the accepted socket won't send the answer simply because no one will dispatch the HS packet to it, as per having id=0. This requires another fix. |
Updated description so that #1648 is not automatically closed after merging this PR. |
A repeated HS CONCLUSION response has:
|
@ethouris Could you please set e.g. 2 seconds of RTT on some link and collect a network capture of the handshake to confirm the issue is resolved? |
Had to perform the test myself. Confirmed that repeated Conclusion Response handshakes have valid content, including correct KMX message. |
Update listener write-ready only after the new connection. Was changed in Haivision#1650, but must not be done at all (see Haivision#1831).
Update listener write-ready only after the new connection. Was changed in Haivision#1650, but must not be done at all (see Haivision#1831).
Update listener write-ready only after the new connection. Was changed in Haivision#1650, but must not be done at all (see Haivision#1831).
Fixes Case 1 in #1648