[BUG] Fixed wrong reaction on failure KMREQ and unsafe construction of EventVariant #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
[core]
maxsharabayko
approved these changes
Nov 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #1666 +/- ##
==========================================
+ Coverage 53.04% 53.31% +0.26%
==========================================
Files 77 77
Lines 17046 17053 +7
==========================================
+ Hits 9042 9091 +49
+ Misses 8004 7962 -42
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1665
This likely wasn't exactly understood as intended by the compiler and some weird copying rules were likely used, which resulted to stack override. Instead a simpler and more straightforward form was provided: construct by explicit constructor and explicit call to EventVariant was therefore needed at the call to
updateCC.processSrtMsg- missing the function call protocolThe protocol mandates that this function return
trueif the message was understood andfalseif not, while no matter if it encountered an error or succeeded, it should return true, just do no response call, or respond with error, depending on a situation. In case of failed KMREQ message it was simply returning false, which was wrong behavior.