Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ANDROID macro #1684

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Remove deprecated ANDROID macro #1684

merged 2 commits into from
Dec 1, 2020

Conversation

sergeiignatov
Copy link
Contributor

@sergeiignatov sergeiignatov commented Dec 1, 2020 •
edited
Loading

ANDROID macro was deprecated in favor of __ANDROID__ , so there is no need to test against it now. Also there is no need to have own ANDROID macro, because __ANDROID__ is already set by NDK.

https://sites.google.com/site/sustainpace1/android/framework/ndk/ndk-r7-document/ndk-r7-changeshtml

Note that the ANDROID macro, is now deprecated. While it is still defined
by the NDK, you should modify your code to test against __ANDROID__ instead!

@codecov

This comment has been minimized.

Sign in to view
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Dec 1, 2020
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Dec 1, 2020
@maxsharabayko maxsharabayko merged commit d3ad2a4 into Haivision:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko approved these changes

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeiignatov @maxsharabayko