Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Refactored member pointer: now raw pointer to socket data #1696

Merged
merged 3 commits into from
Dec 18, 2020

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Dec 4, 2020

This changes the field m_IncludedIter so that it contains the pointer to the member data, instead of the iterator in the list that holds it. Due to that the "NULL iterator" implemented by an empty static list can be also replaced by NULL.

This involves also renaming the group pointer and group member data pointer to m_GroupOf and m_GroupMemberData resp.

@ethouris ethouris marked this pull request as draft December 4, 2020 15:13
@codecov

This comment has been minimized.

@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Dec 9, 2020
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Dec 9, 2020
srtcore/api.h Show resolved Hide resolved
srtcore/group.cpp Show resolved Hide resolved
@ethouris ethouris marked this pull request as ready for review December 17, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants