Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fixed wrong description concerning passphrase #1701

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Dec 9, 2020

No description provided.

@ethouris ethouris added the [docs] Area: Improvements or additions to documentation label Dec 9, 2020
@ethouris ethouris added this to the v1.4.3 milestone Dec 9, 2020
@maxsharabayko maxsharabayko added the Type: Maintenance Work required to maintain or clean up the code label Dec 9, 2020
@codecov

This comment has been minimized.


When a socket with configured passphrase is being connected, the peer must
have the same password set, or otherwise the connection is rejected. This
behavior can be changed by [`SRTO_ENFORCEDENCRYPTION`](#SRTO_ENFORCEDENCRYPTION).

Note that since the introduction of bidirectional support, there's only one
initial SEK to encrypt the stream (new keys after refreshing will be updated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not part of the PR changes but I have been surprise by this 'SEK' popping here. I don't see it defined around while the KEK is written in full word two paragraphs before. Is there a lexicon we can link to.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may link to the Encryption section of the RFC.
This information about SEK is maybe extra in this document: too detailed. I mean, "there's only one
initial SEK to encrypt...".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd simply replace it with "encryption key".

Comment on lines 870 to 872
disables it, if an empty passphrase is passed). The password must be minimum
10 and maximum 79 characters long. If an empty password is specified (default),
the encryption is disabled.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence "If an empty password is specified (default),
the encryption is disabled." is redundant (see line 870)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. How I overlooked it. Will be removed.

Comment on lines 878 to 880
When a socket with configured passphrase is being connected, the peer must
have the same password set, or otherwise the connection is rejected. This
behavior can be changed by [`SRTO_ENFORCEDENCRYPTION`](#SRTO_ENFORCEDENCRYPTION).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a socket with configured passphrase is being connected, the peer must
have the same password set, or the connection is rejected. This
behavior can be changed by SRTO_ENFORCEDENCRYPTION.

Copy link
Collaborator

@stevomatthews stevomatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits

@maxsharabayko maxsharabayko merged commit 6f953e3 into Haivision:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[docs] Area: Improvements or additions to documentation Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants