Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fixed guard for rcv-rexmit fields #1859

Merged
merged 5 commits into from
Feb 10, 2023

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Mar 12, 2021

Problem: The following fields should be declared as guarded by m_RecvAckLock:

  • m_iFlowWindowSize
  • m_iSndLastAck
  • m_tsLastRspTime
  • m_iSndLastAck

They are already guarded in other places; this fix makes the guard consistent, including in places where these data are being read.

Tested with a trial transmission with the use of broadcast group. No deadlocks found and the lock ordering rule described in LowLevelInfo is preserved.

@ethouris ethouris added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Mar 16, 2021
@maxsharabayko maxsharabayko added this to the v1.4.4 milestone May 10, 2021
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Aug 17, 2021
Imported from Haivision#1859.

Co-authored-by:  Mikolaj Malecki <mmalecki@haivision.com>
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Aug 17, 2021
Imported from Haivision#1859.

Co-authored-by:  Mikolaj Malecki <ethouris@gmail.com>
maxsharabayko added a commit that referenced this pull request Aug 17, 2021
Imported from #1859.

Co-authored-by:  Mikolaj Malecki <ethouris@gmail.com>
@maxsharabayko maxsharabayko modified the milestones: v1.4.4, v1.4.5 Aug 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1859 (bd86d52) into master (bc5a642) will increase coverage by 0.03%.
The diff coverage is 67.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
+ Coverage   64.57%   64.61%   +0.03%     
==========================================
  Files          91       91              
  Lines       19307    19317      +10     
==========================================
+ Hits        12467    12481      +14     
+ Misses       6840     6836       -4     
Impacted Files Coverage Δ
srtcore/group.cpp 36.96% <12.50%> (ø)
srtcore/core.h 79.26% <50.00%> (ø)
srtcore/core.cpp 59.59% <63.33%> (+0.14%) ⬆️
srtcore/api.cpp 51.47% <68.14%> (-0.03%) ⬇️
test/test_file_transmission.cpp 95.65% <93.33%> (-0.69%) ⬇️
srtcore/api.h 96.87% <100.00%> (+0.44%) ⬆️
srtcore/sync.cpp 86.66% <0.00%> (-2.23%) ⬇️
srtcore/congctl.cpp 78.64% <0.00%> (-2.09%) ⬇️
srtcore/queue.cpp 79.68% <0.00%> (-1.46%) ⬇️
test/test_bonding.cpp 97.84% <0.00%> (-0.54%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675e75d...bd86d52. Read the comment docs.

@maxsharabayko maxsharabayko modified the milestones: v1.5.0, Next Release May 4, 2022
@maxsharabayko maxsharabayko modified the milestones: v1.5.1, Next release Sep 12, 2022
@maxsharabayko maxsharabayko merged commit e9a3955 into Haivision:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants