Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use-after-free in rendezvous queue #1919

Merged
merged 1 commit into from
May 11, 2021

Conversation

quink-black
Copy link
Contributor

./test-srt --gtest_filter=TestEnforcedEncryption.CASE_B_2_NonBlocking*

==24654==ERROR: AddressSanitizer: heap-use-after-free on address 0x62a000000f40 at pc 0x000109e6c756 bp 0x700000512550 sp 0x700000512548
READ of size 8 at 0x62a000000f40 thread T6
#0 0x109e6c755 in srt::sync::TimePointsrt::sync::steady_clock::TimePoint(srt::sync::TimePointsrt::sync::steady_clock const&) sync.h:189
#1 0x109df3f6c in srt::sync::TimePointsrt::sync::steady_clock::TimePoint(srt::sync::TimePointsrt::sync::steady_clock const&) sync.h:190
#2 0x10a1f0bfb in CRendezvousQueue::updateConnStatus(EReadStatus, EConnectStatus, CPacket const&) queue.cpp:949
#3 0x10a1fa38a in CRcvQueue::worker(void*) queue.cpp:1337
#4 0x7fff2032c94f in _pthread_start+0xdf (libsystem_pthread.dylib:x86_64+0x694f)
#5 0x7fff2032847a in thread_start+0xe (libsystem_pthread.dylib:x86_64+0x247a)

./test-srt  --gtest_filter=TestEnforcedEncryption.CASE_B_2_NonBlocking*

==24654==ERROR: AddressSanitizer: heap-use-after-free on address 0x62a000000f40 at pc 0x000109e6c756 bp 0x700000512550 sp 0x700000512548
READ of size 8 at 0x62a000000f40 thread T6
    #0 0x109e6c755 in srt::sync::TimePoint<srt::sync::steady_clock>::TimePoint(srt::sync::TimePoint<srt::sync::steady_clock> const&) sync.h:189
    Haivision#1 0x109df3f6c in srt::sync::TimePoint<srt::sync::steady_clock>::TimePoint(srt::sync::TimePoint<srt::sync::steady_clock> const&) sync.h:190
    Haivision#2 0x10a1f0bfb in CRendezvousQueue::updateConnStatus(EReadStatus, EConnectStatus, CPacket const&) queue.cpp:949
    Haivision#3 0x10a1fa38a in CRcvQueue::worker(void*) queue.cpp:1337
    Haivision#4 0x7fff2032c94f in _pthread_start+0xdf (libsystem_pthread.dylib:x86_64+0x694f)
    Haivision#5 0x7fff2032847a in thread_start+0xe (libsystem_pthread.dylib:x86_64+0x247a)
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior labels Apr 28, 2021
@maxsharabayko maxsharabayko added this to the v1.4.4 milestone Apr 28, 2021
@maxsharabayko maxsharabayko merged commit 34e14ab into Haivision:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants