Fix GC stop handling #1950
Merged
Fix GC stop handling #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quink-black
force-pushed
the
fix-thread-safety
branch
from
0e97cdd
to
8a7ef48
Compare
1. Protect m_bClosing by m_GCStopLock 2. Fix the issue that m_GCStopLock can be setup multiple times and never be released. srt_startup()/srt_cleanup() meant to be called only once, but it doesn't be used this way in FFmpeg/VLC/GStreamer.
quink-black
force-pushed
the
fix-thread-safety
branch
from
8a7ef48
to
00e6ecf
Compare
maxsharabayko
added
[core]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
never be released. srt_startup()/srt_cleanup() meant to be called
only once, but it doesn't be used this way in FFmpeg/VLC/GStreamer.