Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Check invalid sockopt values #1956

Merged
merged 9 commits into from
Apr 19, 2021
Merged

[API] Check invalid sockopt values #1956

merged 9 commits into from
Apr 19, 2021

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Apr 16, 2021 •
edited
Loading

srt_setsockopt(..):

  • SRTO_CONNTIMEO: return error setting negative value
  • SRTO_PAYLOADSIZE: return error setting negative value, fix FEC validation.
  • SRTO_SNDDROPDELAY >= -1
  • SRTO_SNDTIMEO >= -1
  • SRTO_*LATENCY >= 0
  • SRTO_PEERIDLETIMEO >= 0

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [API] Area: Changes in SRT library API labels Apr 16, 2021
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Apr 16, 2021
@maxsharabayko maxsharabayko marked this pull request as ready for review April 16, 2021 11:50
@maxsharabayko maxsharabayko mentioned this pull request Apr 19, 2021
Merged
2 tasks
@maxsharabayko maxsharabayko merged commit 3bf5ceb into Haivision:master Apr 19, 2021
@maxsharabayko maxsharabayko deleted the hotfix/sockopt-invalid-vals branch April 19, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris left review comments

Assignees
No one assigned
Labels
[API] Area: Changes in SRT library API Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@maxsharabayko @ethouris