Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fixed skip non-empty data #2033

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

gou4shi1
Copy link
Contributor

@gou4shi1 gou4shi1 commented Jun 2, 2021

Fixed a issue introduced by #2026
The skipData() after getRcvFirstMsg() can only skip empty data,
while #2026 may skip multiple non-empty ready-to-play packets that smaller than group recv base.

@maxsharabayko maxsharabayko added this to the v1.4.4 milestone Jun 2, 2021
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior labels Jun 2, 2021
@gou4shi1
Copy link
Contributor Author

gou4shi1 commented Jun 2, 2021

Thanks for the approval, I made a typo, I'm fixing, plz don't merge yet, LOL

@gou4shi1
Copy link
Contributor Author

gou4shi1 commented Jun 2, 2021

Fixed, now it works fine in my production env, but the github CI failed, is it unstable or my code is buggy?

@maxsharabayko
Copy link
Collaborator

TestConnection.Multiple unfortunately tends to fail often. Nothing to do with your PR.

@maxsharabayko maxsharabayko merged commit acf38a7 into Haivision:master Jun 3, 2021
@gou4shi1 gou4shi1 deleted the fix-skip-none-empty-data branch June 3, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants