Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Added fixes for FEC test occasional failure #2037

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Jun 7, 2021

This adds fixes:

  1. Extended timeout for srt_accept_bond call to 2 seconds.
  2. Preinitialized buffers for extracted FEC configuration (happened to be displayed with garbage contents)
  3. Made the accept failure assert instead of expect (failure will only lead to other failures).

@codecov-commenter
Copy link

Codecov Report

Merging #2037 (36b1d77) into master (5205c3c) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2037      +/-   ##
==========================================
- Coverage   63.74%   63.63%   -0.12%     
==========================================
  Files          89       89              
  Lines       18954    18968      +14     
==========================================
- Hits        12083    12071      -12     
- Misses       6871     6897      +26     
Impacted Files Coverage Δ
test/test_fec_rebuilding.cpp 100.00% <100.00%> (ø)
srtcore/list.cpp 76.33% <0.00%> (-5.36%) ⬇️
srtcore/core.h 79.26% <0.00%> (-3.66%) ⬇️
srtcore/window.h 96.72% <0.00%> (-3.28%) ⬇️
test/test_bonding.cpp 97.84% <0.00%> (-0.54%) ⬇️
srtcore/core.cpp 58.31% <0.00%> (-0.27%) ⬇️
srtcore/api.cpp 51.60% <0.00%> (+0.05%) ⬆️
srtcore/queue.cpp 81.28% <0.00%> (+0.58%) ⬆️
srtcore/congctl.cpp 82.81% <0.00%> (+2.08%) ⬆️
srtcore/cache.h 83.07% <0.00%> (+3.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5205c3c...36b1d77. Read the comment docs.

@maxsharabayko maxsharabayko added [tests] Area: Unit tests Type: Bug Indicates an unexpected problem or unintended behavior labels Jun 7, 2021
@maxsharabayko maxsharabayko added this to the v1.4.4 milestone Jun 7, 2021
@maxsharabayko maxsharabayko merged commit e761745 into Haivision:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[tests] Area: Unit tests Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants