-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Repurpose SRTO_GROUPMINSTABLETIMEO #2081
Merged
maxsharabayko
merged 11 commits into
Haivision:master
from
maxsharabayko:develop/opt-min-response-timeo
Mar 8, 2022
Merged
[core] Repurpose SRTO_GROUPMINSTABLETIMEO #2081
maxsharabayko
merged 11 commits into
Haivision:master
from
maxsharabayko:develop/opt-min-response-timeo
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Enhancement
Indicates new feature requests
[API]
Area: Changes in SRT library API
labels
Aug 12, 2021
maxsharabayko
force-pushed
the
develop/opt-min-response-timeo
branch
from
September 9, 2021 11:01
22cd346
to
1a2b1f5
Compare
maxsharabayko
force-pushed
the
develop/opt-min-response-timeo
branch
from
March 2, 2022 14:28
1a2b1f5
to
015fe1c
Compare
Test Cases1. Several Listeners in a Group, SenderSeveral listeners form a group. Confirm the srt-xtransmit generate "srt://:4201?groupminstabletimeo=70" srt://:4200 -v --sendrate 1Mbps --duration 5s
srt-xtransmit receive "srt://127.0.0.1:4200?grouptype=backup" srt://127.0.0.1:4201 -v 2. One Listener in a Group, SenderOne listener forms a group. Confirm the srt-xtransmit generate "srt://:4201?groupconnect=1&groupminstabletimeo=70" -v --sendrate 1Mbps \
--duration 5s
srt-xtransmit receive "srt://127.0.0.1:4201?grouptype=backup" srt://127.0.0.1:4201 -v 3. A Group of Callers, SenderSeveral callers form a group. Confirm the srt-xtransmit generate "srt://127.0.0.1:4200?grouptype=backup&groupminstabletimeo=70" srt://127.0.0.1:4201 \
--sendrate 1Mbps --duration 5s -v
srt-xtransmit receive "srt://:4200" srt://:4201 -v |
maxsharabayko
changed the title
[core] Repurpose SRTO_GROUPMINRESPONSETIMEO
[core] Repurpose SRTO_GROUPMINSTABLETIMEO
Mar 7, 2022
maxsharabayko
commented
Mar 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor edits to API-socket-options.md
Co-authored-by: stevomatthews <smatthews@haivision.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRTO_GROUPMINSTABLETIMEO
is a socket option for SRT socket group. It does not do anything when set on an individual socket, but when set on a listener socket - it is used to derive the value for a group. Defines the minimum value of the stability timeout for a member socket to be considered unstable.API Changes
SRTO_GROUPSTABTIMEO
toSRTO_GROUPMINSTABLETIMEO
. Default: 60 ms.SRTO_GROUPMINSTABLETIMEO
option can be set on an individual socket and on a group socket.Logic
CUDTGroup::sendBackup_QualifyActiveState(..)
instead of the constant value of 60 ms.URI Scheme
groupminstabletimeo=<int>
Tests
Docs
Fixes #1792
Fixes #2254 (a typo).