Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize libatomic Detection. #2116

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Generalize libatomic Detection. #2116

merged 1 commit into from
Sep 3, 2021

Conversation

jlsantiago0
Copy link
Contributor

This patch generalizes the detection of libatomic and whether it can/should be linked into the SRT library when linking with the static library.

Tested with Android and MacOS 10.5 builds.

@jlsantiago0
Copy link
Contributor Author

NOTE This patch also implements a generic detection of std::atomic and the presence of GCC Atomic Trinsics support in the toolchain as well that could be used to improve srtcore/atomic.h implementation selection if desired.

@maxsharabayko maxsharabayko added this to the v1.4.4 milestone Sep 3, 2021
@codecov-commenter

This comment has been minimized.

@maxsharabayko maxsharabayko added [build] Area: Changes in build files Type: Bug Indicates an unexpected problem or unintended behavior labels Sep 3, 2021
@maxsharabayko
Copy link
Collaborator

Tested on Raspberry Pi provided by @matiaspl .

Build Test 01

Works ✔️

-- STDCXX_SYNC: OFF
-- MONOTONIC_CLOCK: ON

Build Test 02

Works ✔️

-- STDCXX_SYNC: ON
-- MONOTONIC_CLOCK: OFF

@maxsharabayko maxsharabayko merged commit e8f4057 into Haivision:master Sep 3, 2021
@jlsantiago0 jlsantiago0 deleted the libatomic-detect branch September 3, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[build] Area: Changes in build files Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants