Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix build with default configuration for GCC <4.7 #2160

Merged
merged 3 commits into from
Oct 13, 2021
Merged

[build] Fix build with default configuration for GCC <4.7 #2160

merged 3 commits into from
Oct 13, 2021

Conversation

jlsantiago0
Copy link
Contributor

This fixes default build configuration for GCC<4.7. This fixes default build configuration for CentOS<7, Ubuntu<14, and Slackware<14.

This changes sets the ENABLE_CXX11 default to OFF when the compiler is GCC<4.7. c++11 was initially introduced in GCC-4.7.0. This PR allows building of OpenSRT when running cmake without -DENABLE_CXX11=OFF on those platforms.

@maxsharabayko maxsharabayko added [build] Area: Changes in build files Type: Bug Indicates an unexpected problem or unintended behavior labels Oct 12, 2021
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Oct 12, 2021
@maxsharabayko
Copy link
Collaborator

Please update the --enable-c++11 option description in the "build options" document.
The default value is "ON" except for GCC 4.7 and below.

@jlsantiago0 jlsantiago0 changed the title Fix build with default configuration for GCC <4.7 [build] Fix build with default configuration for GCC <4.7 Oct 12, 2021
@maxsharabayko maxsharabayko merged commit 15f33d4 into Haivision:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[build] Area: Changes in build files Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants