Fixed missing ws2_32 lib in Windows installer #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property file libsrt.props did not reference ws2_32.lib. For large applications which already reference the Windows socket library, there is no difference. In small test applications which reference libsrt only, there were undefined symbols.
This comment has been minimized.
This comment has been minimized.
maxsharabayko
added
[build]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property file libsrt.props did not reference ws2_32.lib. For large
applications which already reference the Windows socket library, there
is no difference. In small test applications which reference libsrt only,
there were undefined symbols.