[core] Update group read state using ack instead of first unread seqno #2186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used srt backup mode in 2 links, one 4G, another Wifi, and push live stream on it.
My option is live mode, but tspbd: off, tlpktdrop: off.
When I disconnect the Wifi(main) connection, the group socket will never be readable.
And I check the code, I found the problem.
For example, the buffer state below
After the Wifi disconnected, when recv packet from 4G, the function below will be called.
but It always false, because 4 is less than 5(CUDTGroup::m_RcvBaseSeqNo), and the group socket can not read anymore.
This PR show we should check the group readable using ack seqno instead of first unread seqno in recv buffer.
And it works well in my case.