Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Added and updated description of useful test applications #2191

Merged
merged 5 commits into from
Dec 6, 2021

Conversation

ethouris
Copy link
Collaborator

srt-multiplex.md - changed to srt-test-multiplex.md and updated

Added srt-test-relay.md.

@ethouris ethouris added the [docs] Area: Improvements or additions to documentation label Nov 30, 2021
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "sample applications" section of the docs/README.md also needs an update then.

@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Dec 1, 2021
@maxsharabayko maxsharabayko added the Type: Maintenance Work required to maintain or clean up the code label Dec 1, 2021
@ethouris
Copy link
Collaborator Author

ethouris commented Dec 3, 2021

Ok, updated, and I also added one more lacking description :)

Copy link
Collaborator

@mbakholdina mbakholdina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ethouris, thank you for updating the documentation! A couple of minor comments from me.

docs/README.md Outdated
| [Using the<br /> `srt-tunnel` App](apps/srt-tunnel.md) | [apps](apps/) | [srt-tunnel.md](apps/srt-tunnel.md) | A sample application to set up an SRT tunnel for TCP traffic. |
| <img width=200px height=1px/> | <img width=100px height=1px/> | <img width=200px height=1px/> | <img width=500px height=1px/> |

## Testing applications
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to create a separate table for these 2 items. Please move everything under "Sample Applications" table and delete the current one.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change the folder to "apps" with an appropriate link.

@@ -1,26 +1,27 @@
## srt-multiplex
## srt-test-multiplex
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with the level of headings in this document. It should start with "# srt-test-multiplex" and then "## Usage", etc.. Could you please go through the document and update the levels carefully?

@@ -0,0 +1,34 @@
## srt-test-relay
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, the level of heading is incorrect. Please change ## to #.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also noticed that in srt-tunnel document the headings formatting is different. Could you please update it to look similar? Plus please change the title from "SRT Tunnel" to "srt-tunnel" for consistency. Thanks!

@ethouris
Copy link
Collaborator Author

ethouris commented Dec 3, 2021

Ok, I added fixes, please check again if everything's ok

Copy link
Collaborator

@mbakholdina mbakholdina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethouris , a couple of suggestions.

docs/README.md Outdated Show resolved Hide resolved
docs/apps/srt-tunnel.md Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko merged commit 545700f into Haivision:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[docs] Area: Improvements or additions to documentation Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants