[core] Fix rtt estimate in bidirectional mode #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
[core]
maxsharabayko
approved these changes
Dec 9, 2021
|
AppVeyor build failed, how to restart it?
|
|
@xiaozhihong Restarted, all good now. Thanks for the fix! |
|
The bug was introduced in PR #1863. |
|
@maxsharabayko Unfortunately, there've been more bugs introduced in PR #1863 in this piece of code (the case of bidirectional transmission) and the logic has changed. I'll make a PR tomorrow to fix this. Sounds like I also need to spend some time and go through all the atomic related changes and see whether the RTT logic hasn't been affected somewhere else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bidirectional transport mode, in some cases, RTT is never updated, maybe a spelling mistake?