Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the core stats structure #2212

Merged
merged 7 commits into from
Dec 20, 2021

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Dec 16, 2021

Description

The CoreStats structure contains duplicated fields for trace and total stats. This PR minimizes the structure and allows counting bytes and packets in a single call instead of four lines of operations.

Fixes #1424.
Closes #1471.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Dec 16, 2021
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Dec 16, 2021
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 16, 2021

This pull request introduces 1 alert when merging 49e4541 into 3558cd0 - view on LGTM.com

new alerts:

  • 1 for Multiplication result converted to larger type

@maxsharabayko maxsharabayko marked this pull request as ready for review December 17, 2021 11:37
@maxsharabayko maxsharabayko merged commit 5f7bc23 into Haivision:master Dec 20, 2021
@maxsharabayko maxsharabayko deleted the develop/compact-stats branch December 20, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFAX] Apply consolidation for internal stats in CUDT to use MetricUsage and PacketMetric.
1 participant