Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] add CRcvBufferNew::dropUnitInPos() to simplify dropUpTo() and dropMessage() #2226

Merged
merged 4 commits into from
Jan 17, 2022
Merged

[core] add CRcvBufferNew::dropUnitInPos() to simplify dropUpTo() and dropMessage() #2226

merged 4 commits into from
Jan 17, 2022

Conversation

gou4shi1
Copy link
Contributor

To simplify #2221 and #2222

gou4shi1 added a commit to gou4shi1/srt that referenced this pull request Jan 17, 2022
@gou4shi1
rebase on Haivision#2226
5cd35c5
gou4shi1 added a commit to gou4shi1/srt that referenced this pull request Jan 17, 2022
@gou4shi1
rebase on Haivision#2226
4a359c6
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Jan 17, 2022
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Jan 17, 2022
maxsharabayko
maxsharabayko reviewed Jan 17, 2022
View reviewed changes
srtcore/buffer_rcv.h Outdated Show resolved Hide resolved
gou4shi1 and others added 3 commits January 17, 2022 17:21
@gou4shi1 @maxsharabayko
fix style
b00c285 
Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>
@gou4shi1 @maxsharabayko
fix comment
f3d813b 
Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>
@gou4shi1
make private and rename
8340608
@gou4shi1 gou4shi1 changed the title [core] add CRcvBufferNew::dropUnit() to simplify dropUpTo() and dropMessage() [core] add CRcvBufferNew::dropUnitInPos() to simplify dropUpTo() and dropMessage() Jan 17, 2022
@gou4shi1
Copy link
Contributor Author

made private and renamed to dropUnitInPos() to keep consistent with releaseUnitInPos()

@maxsharabayko maxsharabayko merged commit 31de8aa into Haivision:master Jan 17, 2022
@gou4shi1 gou4shi1 deleted the add-dropUnit branch January 17, 2022 12:54
maxsharabayko pushed a commit that referenced this pull request Jan 18, 2022
@gou4shi1
[core] CRcvBufferNew::dropUpTo() able to drop non-empty units (#2221)
24bf666 
Using fixed TSBPD timebase update (#2226) when dropping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko left review comments

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gou4shi1 @maxsharabayko