Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use SND buffer delay for TL Packet Drop instead of the timespan #2230

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Jan 21, 2022

1. Use SND buffer delay for TL Packet Drop

Use SND buffer delay for TL Packet Drop instead of the timespan between the first and the last packet in the buffer.

Sender dropping logic was applied if the sender buffer timespan exceeds drop_threshold_ms.
Instead, the delay of the oldest packet in the buffer should be used (Tnow - OldestPacketTS).
This also correlates with the usage of the source time if provided to calculate the timestamp, which was not the case previously (PR #2185).

As before, only packets older than Tnow - drop_threshold_ms are dropped by the sender.

Fixes #898.

2. Added missing mutex lock to CSndBuffer::readData(..) function.

For some reason the lock was missing from the CSndBuffer::readData(CPacket& w_packet, ..).

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Jan 21, 2022
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Jan 21, 2022
instead of the timespan between the first and the last packet in the buffer.
@maxsharabayko maxsharabayko merged commit 308cd30 into Haivision:master Jan 24, 2022
@maxsharabayko maxsharabayko deleted the develop/buffering-delay branch January 24, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TL packet drop uses timespan instead of current time (sender side)
1 participant