Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix MaxBW limitation #2232

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Jan 24, 2022

Fixes #713.

  1. Don't reschedule sending (keep pacing) on
    • SND drop,
    • NAK received
    • retransmission timeout.
  2. Added pacing amendment after sending probing packets.

Changes extracted from #2180.

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Jan 24, 2022
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Jan 24, 2022
@maxsharabayko maxsharabayko self-assigned this Jan 24, 2022
@codecov-commenter

This comment has been minimized.

srtcore/core.cpp Outdated Show resolved Hide resolved
Don't reschedule sending (keep pacing) on
- SND drop,
- NAK received
- retransmission timeout.
@maxsharabayko
Copy link
Collaborator Author

maxsharabayko commented Jan 25, 2022

Test Environment

  • Congestion: rate limit (LanForge).
  • Sending rate (source bitrate): 7 Mbps.
  • Network throughput:
    • 8 Mbps (+14%);
    • 5 Mbps (-28%) from 20th to 30th second.
  • SRT Max BW limit: 8 Mbps (+14% from source bitrate).
  • Packet loss: No (only by rate limit).
  • RTT: 40 ms.
  • SRT Latency: 150 ms.
(receiver)
./srt-xtransmit receive srt://:4200 --statsfile stats-rcv.csv --statsfreq 1s --metricsfile stats-metrics.csv \
                --metricsfreq 1s -v --enable-metrics

(sender)
maxbw=1000000
sendrate=7Mbps
./srt-xtransmit generate "srt://ip:4200?maxbw=$maxbw&latency=150" --sendrate $rate --duration 60s \
                --statsfile stats-snd.csv --statsfreq 100ms --enable-metrics -v

This PR

⚠️ 100 ms stats interval on the sender.
image

image

image

SRT master

⚠️ 100 ms stats interval on the sender.
image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TL Packet Drop supresses MAXBW limitation
3 participants