Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Improved group readiness updating in sendCtrlAck() #2245

Merged
merged 1 commit into from
Feb 8, 2022
Merged

[core] Improved group readiness updating in sendCtrlAck() #2245

merged 1 commit into from
Feb 8, 2022

Conversation

gou4shi1
Copy link
Contributor

@gou4shi1 gou4shi1 commented Feb 8, 2022 •
edited
Loading

  • Decouple group_read_seq from ackDataUpTo().
  • If new recv buffer enabled, use getFirstReadablePacketInfo() instead of getAvailablePacketsRange() to support out-of-order messages. This need [core] drop packets in the new recv buffer by group recv base #2207 to make sure getFirstReadablePacketInfo() will not return seq behind group_read_base.
  • If new recv buffer disabled, use decseq(ack) instead of ack.

@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Feb 8, 2022
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Feb 8, 2022
@maxsharabayko maxsharabayko merged commit c885ed1 into Haivision:master Feb 8, 2022
@gou4shi1 gou4shi1 deleted the fix-updateReadState branch February 8, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gou4shi1 @maxsharabayko