Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] prefer to use std::atomic if available #2291

Merged
merged 1 commit into from
Apr 14, 2022
Merged

[core] prefer to use std::atomic if available #2291

merged 1 commit into from
Apr 14, 2022

Conversation

gou4shi1
Copy link
Contributor

@gou4shi1 gou4shi1 commented Apr 13, 2022 •
edited
Loading

Previously it prefer to define ATOMIC_USE_GCC_INTRINSICS which in terms use volatile, but in C++11, we should use std::atomic for concurrency.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [build] Area: Changes in build files [core] Area: Changes in SRT library core and removed [build] Area: Changes in build files labels Apr 13, 2022
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Apr 13, 2022
@maxsharabayko maxsharabayko merged commit 1f8c1e9 into Haivision:master Apr 14, 2022
@gou4shi1 gou4shi1 deleted the fix-atomic branch April 14, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko approved these changes

@ethouris ethouris ethouris approved these changes

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gou4shi1 @ethouris @maxsharabayko