Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fixed updating new RCV buffer on ISN change. #2309

Merged
merged 4 commits into from
Apr 24, 2022

Conversation

maxsharabayko
Copy link
Collaborator

The new receiver buffer keeps track of the packet sequence number in the starting position to be independent from SRT receiver ACK position.
As the receiver buffer is created before the connection is actually being established (see #2268), the starting sequence number has to be updated afterward.

This PR adds an update of the RCV buffer's starting seqno.

@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Apr 22, 2022
@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Apr 22, 2022
@maxsharabayko
Copy link
Collaborator Author

✔️ Tested with main/backup and broadcast groups. No issues.
✔️ Tested with rendezvous connection. No issues.

@maxsharabayko maxsharabayko marked this pull request as ready for review April 22, 2022 15:16
srtcore/buffer_rcv.cpp Outdated Show resolved Hide resolved
srtcore/buffer_rcv.h Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko merged commit 69284ce into Haivision:master Apr 24, 2022
@maxsharabayko maxsharabayko deleted the hotfix/rbuf-rendezvous branch April 24, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
2 participants