[API] Drop EXPERIMENTAL from ENABLE_EXPERIMENTAL_BONDING

[maxsharabayko]

The bonding functionality has been integrated into a number of projects already. Backward compatibility of the SRT behavior on the wire, and SRT API has to be preserved.
Thus, the feature and the API can no longer be treated as "experimental".

The ENABLE_EXPERIMENTAL_BONDING CMake build option has been renamed to ENABLE_BONDING.
It is still disabled by default, as not all the projects would use it. Integrating SRT socket groups would also mean the group API has to be used in addition to the regular API.

It is also important to note that SRT built with ENABLE_BONDING would export more functions, and can't be treated fully ABI-compatible with SRT built without bonding. Probably this aspect should be depicted in having different SONAMEs for the two configurations.

TODO

• Remove unused srt_include(..) and srt_exclude(..) API functions for unimplemented externally-managed groups ([API] Removed unused srt_include(..) and srt_exclude(..) #2321).
• Removed unimplemented BALANCING and MULTICAST socket group types ([API] Removed balancing and multicast group types #2323).
• Unused API function srt_group_configure(..) to be removed.
• Update the API doc on return error codes in case bonding is disabled, but functions are called.

[yaneti]

Could somebody elaborate on the default OFF for bonding ? Does ON make the API or the on the wire protocol incompatible with the old versions? i.e would a program using the library with built-in bonding be unable to talk to old srt senders or receivers or vice-versa ?
I can see why it was off while experimental , but now that its declared stable...

[maxsharabayko]

Enabling bonding features would increase the size of the binary. Being shipped in a number of other open-source projects it makes sense to use the bonding API only once the 3rd party project actually integrates this feature of SRT. Not much sense to enable the feature if it is not used.

[yaneti]

Thanks.
Sounds like the size argument is more applicable to projects vendoring-in the library, while for a shared lib used by potentially more than one program it should definitely be ON. The size difference on Fedora x86_64 build for the library somewhat small, from 723K to 886K

[maxsharabayko]

Just remember SRT is used almost everywhere, including mobile and embedded platforms. I would not be surprised if your fridge would use SRT to do some smart things. Size does matter there. 😄