Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OpenSSL EVP API support to HaiCrypt (--use-enclib=openssl-evp). #2333

Merged
merged 10 commits into from
Jun 17, 2022

Conversation

jeandube
Copy link
Collaborator

@jeandube jeandube commented May 12, 2022

Changes to CRYSPR framework required (-DCRYSPR2).
cryspr for openssl and openssl-evp tested
cryspr for gnutls and mbedtls upgraded for CRYSPR2 but not compiled nor tested with -DCRYSPR2
both can still be built with/without -DCRYSPR2.

Fixes #2141.

Changes to CRYSPR framework required (-DCRYSPR2).
cryspr for openssl and openssl-evp tested
cryspr for gnutls and mbedtls upgraded for CRYSPR2 but not compiled nor tested with -DCRYSPR2
both can still be built with/without -DCRYSPR2.
@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [core] Area: Changes in SRT library core labels May 12, 2022
@maxsharabayko maxsharabayko added this to the Next Release milestone May 12, 2022
@maxsharabayko
Copy link
Collaborator

maxsharabayko commented May 19, 2022

Reviewer Notes (In Progress)

haicrypt/cryspr-openssl-evp.h Outdated Show resolved Hide resolved
haicrypt/cryspr.c Outdated Show resolved Hide resolved
haicrypt/cryspr-openssl-evp.h Outdated Show resolved Hide resolved
haicrypt/cryspr-openssl.c Outdated Show resolved Hide resolved
Get rid of Cryspr method difference if !CRYSPR2
@jeandube jeandube requested a review from ethouris June 1, 2022 17:35
@maxsharabayko
Copy link
Collaborator

A patch to add openssl-evp option value to the USE_ENCLIB build option description in docs/build/build-options.md,

index 8c87229c..bd20501a 100644
--- a/docs/build/build-options.md
+++ b/docs/build/build-options.md
@@ -58,7 +58,7 @@ Option details are given further below.
 | [`PTHREAD_LIBRARY`](#pthread_library)                        | 1.3.0 | `STRING`  | OFF        | Configures the path to a pthread library.  |
 | [`USE_BUSY_WAITING`](#use_busy_waiting)                      | 1.3.3 | `BOOL`    | OFF        | Enables more accurate sending times at the cost of potentially higher CPU load. |
 | [`USE_CXX_STD`](#use_cxx_std)                                | 1.4.2 | `STRING`  | OFF        | Enforces using a particular C++ standard (11, 14, 17, etc.) when compiling. |
-| [`USE_ENCLIB`](#use_enclib)                                  | 1.3.3 | `STRING`  | openssl    | Encryption library to be used (`openssl`, `gnutls`, `mbedtls`).  |
+| [`USE_ENCLIB`](#use_enclib)                                  | 1.3.3 | `STRING`  | openssl    | Encryption library to be used (`openssl`, `openssl-evp`, `gnutls`, `mbedtls`).  |
 | [`USE_GNUSTL`](#use_gnustl)                                  | 1.3.4 | `BOOL`    | OFF        | Use `pkg-config` with the `gnustl` package name to extract the header and library path for the C++ standard library.  |
 | [`USE_OPENSSL_PC`](#use_openssl_pc)                          | 1.3.0 | `BOOL`    | ON         | Use `pkg-config` to find OpenSSL libraries.  |
 | [`OPENSSL_USE_STATIC_LIBS`](#openssl_use_static_libs)        | 1.5.0 | `BOOL`    | OFF        | Link OpenSSL statically.  |
@@ -534,6 +534,7 @@ remember that:
 Encryption library to be used. Possible options for `<name>`:
 
 * openssl (default)
+* openssl-evp (OpenSSL EVP API)
 * gnutls (with nettle)
 * mbedtls

@maxsharabayko maxsharabayko merged commit c5f613e into Haivision:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Add Support for OpenSSL 3.0
3 participants