Build: Add 'ENABLE BONDING' option to Windows PowerShell build script #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-update of cmake within the script (old cmake ver had openssl problem)
maxsharabayko
added
Type: Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optiont to turn on bonding when using the Windows PowerShell build script - it is just a simple pass-through to the CMAKE arguments.
This change then allows the AppVeyor builds to enable bonding - I have set the Release builds of VS2015 and VS2019 to run with this now set to 'ON'.
A secondary small change is to bump the auto-installed CMAKE that the script offers (if not found) to a newer version - the prior version had some problems compiling SSL due to a known (and resolved) CMAKE script problem.