Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Minor fix for Bonding.CloseGroupAndSocket #2406

Merged

Conversation

maxsharabayko
Copy link
Collaborator

In the Bonding.CloseGroupAndSocket unit test (If a listener is not available) the following IPE situation can happen when sockets already removed from the epoll are being removed again.
Added ASSERT_GT(epoll_res, 0) to fail the test if epoll returns an error.

[ RUN      ] Bonding.CloseGroupAndSocket
22: Created group socket: 1405307167
22: Connecting two sockets 
22: Socket created: 331565342
22: Listen: wait for acceptability
22: Socket created: 331565340
22: Returned from connecting two sockets 
22: Listen: reported 1 acceptable and 0 errors
22: Listener will read packets...
22: Epoll result: 2
22: Epoll rlen: 0, wlen: 2
22: Epoll write[0]: 331565342 (removed from epoll)
22: Epoll write[1]: 1405307167 (removed from epoll)
22: Connect callback. Socket: 331565340, error: 1001, token: 2
22: 13:40:54.880000/T6716*E:SRT.ea: EID:3 no sockets to check, this would deadlock
22: Epoll result: -1
22: Epoll rlen: 0, wlen: 2
22: Epoll write[0]: 331565342 (removed from epoll)
22: 13:40:54.880000/T6716*E:SRT.ei: epoll/update: IPE: update struck E3 which is NOT SUBSCRIBED to @331565342
22: Epoll write[1]: 1405307167 (removed from epoll)
22: 13:40:54.880000/T6716*E:SRT.ei: epoll/update: IPE: update struck E3 which is NOT SUBSCRIBED to @1405307167

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [tests] Area: Unit tests labels Jul 12, 2022
@maxsharabayko maxsharabayko added this to the Next Release milestone Jul 12, 2022
@maxsharabayko maxsharabayko merged commit 0153f69 into Haivision:master Jul 13, 2022
@maxsharabayko maxsharabayko deleted the tests/Bonding-CloseGroupAndSocket branch July 13, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[tests] Area: Unit tests Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant