Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] export functions in mingw-w64 when building as a DLL #2451

Merged
merged 1 commit into from
Sep 5, 2022
Merged

[core] export functions in mingw-w64 when building as a DLL #2451

merged 1 commit into from
Sep 5, 2022

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Sep 2, 2022

mingw-w64 supports __declspec(dllexport) and __declspec(import)

@maxsharabayko maxsharabayko added this to the Next Release milestone Sep 2, 2022
@robUx4
[core] export functions in mingw-w64 when building as a DLL
1a4a798 
mingw-w64 supports __declspec(dllexport) and __declspec(import)
@robUx4
Copy link
Contributor Author

robUx4 commented Sep 5, 2022

Added missing else for other targets

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [API] Area: Changes in SRT library API labels Sep 5, 2022
@maxsharabayko maxsharabayko merged commit ec52c45 into Haivision:master Sep 5, 2022
@robUx4 robUx4 deleted the mingw-dll branch September 5, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[API] Area: Changes in SRT library API Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@robUx4 @maxsharabayko