[core] Improved m_FreshLoss and m_pRcvLossList in processData() #2470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists two commits:
Moved m_FreshLoss.push_back() out of the incoming loop.
Previously,
m_FreshLoss.push_back()
happened insideresult that
srt_loss_seqs
will be added and logged repeatedly.Also protected m_pRcvLossList->insert() with m_RcvBufferLock.
m_FreshLoss
andm_pRcvLossList
at the same time to improve their consistency and reduce onem_RcvLossLock
.processData()
andtsbpd()
, related PR [core] make sure data to be inserted into CRcvLossList are monotonic #2195, I found that the error logs of that PR happened frequently when the workload is high.