Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Changes
SRTO_CRYPTOMODE
where0
means the standard AES-CTR;1
enables AES GCM.SRT_KM_S_BADCRYPTOMODE
to signal rejection due to crypto mode mismatch.SRT_REJ_CRYPTO
.Functional Changes
When TSBPD is disabled, exclude the timestamp field from the encryption (Receiver, Sender).Maybe temporarily disable AEAD if TSBPD is disabled.Documentation Updates
SRTO_CRYPTOMODE
.SRT_KM_S_BADCRYPTOMODE
rejection reason.Sample Applications
cryptomode
.Unit Tests
CCryptoControl
.To Consider
MaybeSRTO_CIPHERSUITE
instead ofSRTO_CRYPTOMODE
?