Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-win.md #2487

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Update build-win.md #2487

merged 2 commits into from
Oct 14, 2022

Conversation

cmollahan
Copy link
Collaborator

Fixed links in the table of contents.
Replaced the Win64OpenSSL download link. NOTE: I inserted the link you sent on Slack, but this seems to download the 32-bit version of the installer. Should the correct link be: http://slproweb.com/download/Win64OpenSSL_Light-3_0_5.exe ? If so, let me know and I will make another pull request.

Fixed links in the table of contents.
Replaced the Win64OpenSSL download link. NOTE: I inserted the link you sent on Slack, but this seems to download the 32-bit version of the installer. Should the correct link be: http://slproweb.com/download/Win64OpenSSL_Light-3_0_5.exe ? If so, let me know and I will make another pull request.
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #2487 (53d6708) into master (04369b8) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2487      +/-   ##
==========================================
- Coverage   66.10%   66.01%   -0.10%     
==========================================
  Files          96       96              
  Lines       19599    19601       +2     
==========================================
- Hits        12956    12939      -17     
- Misses       6643     6662      +19     
Impacted Files Coverage Δ
srtcore/list.cpp 77.77% <0.00%> (-5.15%) ⬇️
srtcore/cache.h 80.00% <0.00%> (-3.08%) ⬇️
srtcore/queue.cpp 80.89% <0.00%> (-0.30%) ⬇️
srtcore/core.cpp 60.05% <0.00%> (-0.10%) ⬇️
srtcore/api.cpp 52.98% <0.00%> (-0.06%) ⬇️
srtcore/buffer_rcv.cpp 59.02% <0.00%> (+0.38%) ⬆️
test/test_bonding.cpp 98.42% <0.00%> (+0.52%) ⬆️
srtcore/buffer_snd.cpp 66.85% <0.00%> (+0.57%) ⬆️
srtcore/core.h 78.75% <0.00%> (+6.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [docs] Area: Improvements or additions to documentation labels Oct 13, 2022
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Oct 13, 2022
docs/build/build-win.md Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko merged commit e0a25d0 into Haivision:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[docs] Area: Improvements or additions to documentation Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants