Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: fixed wrong description of PBKEYLEN conflict resolution #2513

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Nov 2, 2022

Fixes #2496

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #2513 (e095d5f) into master (53735e1) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
- Coverage   65.48%   65.28%   -0.21%     
==========================================
  Files          99      100       +1     
  Lines       19698    19767      +69     
==========================================
+ Hits        12900    12904       +4     
- Misses       6798     6863      +65     
Impacted Files Coverage Δ
srtcore/packet.cpp 44.04% <0.00%> (-8.43%) ⬇️
srtcore/group.cpp 29.37% <0.00%> (-8.27%) ⬇️
srtcore/utilities.h 59.85% <0.00%> (-4.23%) ⬇️
test/test_bonding.cpp 94.21% <0.00%> (-4.22%) ⬇️
srtcore/group.h 59.18% <0.00%> (-2.05%) ⬇️
srtcore/window.cpp 81.81% <0.00%> (-1.30%) ⬇️
srtcore/netinet_any.h 88.77% <0.00%> (-1.03%) ⬇️
srtcore/buffer_rcv.cpp 58.83% <0.00%> (-0.20%) ⬇️
srtcore/core.h 72.15% <0.00%> (ø)
srtcore/queue.h 82.35% <0.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ethouris ethouris added the [docs] Area: Improvements or additions to documentation label Nov 2, 2022
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Nov 2, 2022
@maxsharabayko maxsharabayko added the Type: Bug Indicates an unexpected problem or unintended behavior label Nov 2, 2022
Copy link
Collaborator

@stevomatthews stevomatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits.

Co-authored-by: stevomatthews <smatthews@haivision.com>
Co-authored-by: stevomatthews <smatthews@haivision.com>
@maxsharabayko maxsharabayko merged commit a791156 into Haivision:master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[docs] Area: Improvements or additions to documentation Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix the unwanted behavior case description of the SRTO_PBKEYLEN
4 participants