Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refax: Cleanup for bonding conditionals and unused code #2525

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Refax: Cleanup for bonding conditionals and unused code #2525

merged 1 commit into from
Nov 9, 2022

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Nov 9, 2022

  1. Added exclusion for non-bonding for fields in CUDT that are not in use when bonding is off
  2. Changed bonding test conditional from "masking whole file" to conditional in the filelist
  3. Removed unused CUDT::defaultPacketArrival. This function was planned to be an alternative loss handling for the case of common-buffer groups, but things have changed largely in the meantime and this function is no longer necessary, and not used in the new group code.
  4. In test_bonding.cpp deleted lines with unused includes and defines.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Nov 9, 2022
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Nov 9, 2022
@maxsharabayko maxsharabayko merged commit 932e5bd into Haivision:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko Awaiting requested review from maxsharabayko

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ethouris @maxsharabayko