Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refax: remove usage of LOGF/HLOGF #2566

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Dec 1, 2022

Requested by #2126.

The LOGF/HLOGF macros haven't been removed, just in case, but their usage will be now deprecated. The form method of the log dispatcher, which is being used in this macro, has been marked deprecated in order to make it loud. All uses of LOGF macros have been replaced with LOGC or LOGP.

Note that this has no influence on the logging in haicrypt, as it uses vform, not form method through the wrapper functions.

@ethouris ethouris added Type: Maintenance Work required to maintain or clean up the code [build] Area: Changes in build files labels Dec 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2566 (592dd1d) into master (fdb9389) will increase coverage by 0.32%.
The diff coverage is 43.33%.

@@            Coverage Diff             @@
##           master    #2566      +/-   ##
==========================================
+ Coverage   65.91%   66.23%   +0.32%     
==========================================
  Files         100      100              
  Lines       19822    19793      -29     
==========================================
+ Hits        13065    13110      +45     
+ Misses       6757     6683      -74     
Impacted Files Coverage Δ
srtcore/logging.h 98.21% <ø> (+3.76%) ⬆️
srtcore/core.cpp 60.88% <40.74%> (+0.98%) ⬆️
srtcore/api.cpp 53.28% <66.66%> (ø)
srtcore/cache.h 80.00% <0.00%> (-3.08%) ⬇️
srtcore/common.cpp 37.32% <0.00%> (-0.93%) ⬇️
srtcore/buffer_snd.cpp 67.10% <0.00%> (-0.66%) ⬇️
srtcore/queue.cpp 81.00% <0.00%> (-0.30%) ⬇️
srtcore/congctl.cpp 84.45% <0.00%> (+3.62%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxsharabayko maxsharabayko merged commit fc82eac into Haivision:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[build] Area: Changes in build files Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants