[API] Crypto mode 'auto' implemented for listener. #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Enhancement
25 tasks
maxsharabayko
commented
Dec 8, 2022
maxsharabayko
force-pushed
the
develop/aead-crypto-auto
branch
2 times, most recently
from
3baba24
to
0416b96
Compare
Caller or rendezvous still falls back to AES-CTR.
maxsharabayko
force-pushed
the
develop/aead-crypto-auto
branch
from
0416b96
to
adc60c5
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Co-authored-by: stevomatthews <smatthews@haivision.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an SRT listener to accept any crypto mode (AES-GCM or AES-CTR) the
SRTO_CRYPTOMODE=0(Auto) can be used.When
SRTO_CRYPTOMODE=0(Auto) is set on an SRT Caller or SRT Rendezvous the actual mode to be negotiated is AES-CTR.This change does not require further HS changes on the wire, still allows to let the listener to accept any crypto mode.
Once a connection is established, the actual crypto mode is returned via the
SRTO_CRYPTOMODE: 1 (AES-CTR) or 2 (AES-GCM).