Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Removed reference fields from CPacket pinned to the SRT header #2594

Merged
merged 14 commits into from
Feb 16, 2024

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Dec 23, 2022

Reference fields like m_iSeqNo that were set to the value in the objects self parts of the array keeping the header have been turned into methods.

Only m_pcData is left unchanged because this is much more complicated.

@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Feb 9, 2023
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Feb 9, 2023
ethouris pushed a commit to ethouris/srt that referenced this pull request May 8, 2023
ethouris pushed a commit that referenced this pull request May 8, 2023
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (8b73dbc) 66.99% compared to head (bca5bb2) 66.79%.
Report is 3 commits behind head on master.

❗ Current head bca5bb2 differs from pull request most recent head 5c3abbc. Consider uploading reports for the commit 5c3abbc to get more accurate results

Files Patch % Lines
srtcore/core.cpp 61.90% 32 Missing ⚠️
srtcore/buffer_snd.cpp 66.66% 2 Missing ⚠️
srtcore/packet.cpp 0.00% 1 Missing ⚠️
srtcore/packetfilter.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2594      +/-   ##
==========================================
- Coverage   66.99%   66.79%   -0.20%     
==========================================
  Files         103      103              
  Lines       20460    20470      +10     
==========================================
- Hits        13707    13673      -34     
- Misses       6753     6797      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider minor comments.
I am a bit concerned the naming convention is not followed, i.e. set_timestamp instead of setTimestamp function names are used. I guess that might be tricky to do set with upper case, but get without the get itself, only using the work starting with lowercase.

test/test_buffer_rcv.cpp Outdated Show resolved Hide resolved
test/test_buffer_rcv.cpp Show resolved Hide resolved
Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>
@ethouris ethouris marked this pull request as ready for review February 16, 2024 14:36
@maxsharabayko maxsharabayko merged commit e0d4227 into Haivision:master Feb 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants