Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixed default reject reason for a listener callback and wrong handling of a listener's reject response #2605

Merged

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Jan 9, 2023

Fixes #2559

  1. Setting the SRT_REJX_FALLBACK value in the listener callback in order to give it a default value for the case of rejection request, and clearing this value in case when the rejection reason was mistakenly set by the callback, but it resulted in acceptance.
  2. Fixed the bug in the caller's handling of the listener's rejection callback - value exactly equal to URQ_FAILURE was not treated as error.

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Jan 10, 2023
@maxsharabayko maxsharabayko added this to the v1.5.2 milestone Jan 10, 2023
@maxsharabayko maxsharabayko merged commit 04e8dbc into Haivision:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The default group HS rejection reason code
2 participants