Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/TEST] Refaxed and fixed multiplexer reusage. Fixed ReuseAddr tests. #2608

Merged
merged 24 commits into from
Feb 2, 2023

Conversation

ethouris
Copy link
Collaborator

Fixes #2389

Changes:

  1. Reworked the procedure of finding the matching or conflicting multiplexer (some IPv6-related cases were incorrectly checking the cases of IPv6 only and IPv6+IPv4).
  2. Obtaining the IPPROTO_IPV6/IPV6_V6ONLY flag from the socket in case of AF_INET6 family just after socket creation so that this flag can be checked when searching for a matching multiplexer binding.
  3. Reworked and fixed UT for ReuseAddr.* - removed or put under a better control tests that were relying on a half-cleanedup previously bound sockets.

@ethouris ethouris marked this pull request as ready for review January 11, 2023 18:00
@ethouris ethouris marked this pull request as draft January 25, 2023 13:20
@ethouris ethouris marked this pull request as ready for review January 25, 2023 13:24
@maxsharabayko maxsharabayko added this to the v1.5.2 milestone Jan 25, 2023
@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Jan 25, 2023
Co-authored-by: stevomatthews <smatthews@haivision.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2608 (d777686) into master (30f6f6b) will decrease coverage by 0.51%.
The diff coverage is 52.02%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
- Coverage   66.53%   66.03%   -0.51%     
==========================================
  Files          99       99              
  Lines       19843    20043     +200     
==========================================
+ Hits        13203    13235      +32     
- Misses       6640     6808     +168     
Impacted Files Coverage Δ
srtcore/api.h 96.55% <ø> (ø)
srtcore/channel.cpp 43.42% <0.00%> (-2.21%) ⬇️
srtcore/channel.h 0.00% <0.00%> (ø)
srtcore/api.cpp 52.72% <41.53%> (-0.48%) ⬇️
test/test_reuseaddr.cpp 64.85% <58.76%> (-15.44%) ⬇️
srtcore/socketconfig.h 90.00% <100.00%> (+0.16%) ⬆️
srtcore/list.cpp 76.69% <0.00%> (-9.28%) ⬇️
srtcore/window.h 96.72% <0.00%> (-3.28%) ⬇️
haicrypt/hcrypt_tx.c 17.14% <0.00%> (-1.28%) ⬇️
srtcore/core.cpp 60.92% <0.00%> (-0.33%) ⬇️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

docs/API/API-functions.md Outdated Show resolved Hide resolved
docs/API/API-socket-options.md Outdated Show resolved Hide resolved
srtcore/api.cpp Outdated Show resolved Hide resolved
srtcore/api.cpp Outdated Show resolved Hide resolved
srtcore/api.cpp Outdated Show resolved Hide resolved
srtcore/socketconfig.h Show resolved Hide resolved
srtcore/socketconfig.h Show resolved Hide resolved
srtcore/api.cpp Outdated Show resolved Hide resolved
@stevomatthews
Copy link
Collaborator

Review pass completed with minor edits/suggestions.

docs/API/API-functions.md Outdated Show resolved Hide resolved
ethouris and others added 2 commits February 1, 2023 11:35
Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
srtcore/api.h Outdated Show resolved Hide resolved
srtcore/api.cpp Outdated Show resolved Hide resolved
Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>
Co-authored-by: stevomatthews <smatthews@haivision.com>
@maxsharabayko maxsharabayko merged commit 8db35de into Haivision:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Test ReuseAddr.ProtocolVersion fails
4 participants