[TEST] Added check for read-ready for decryption failure case #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
requested changes
Jan 26, 2023
Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>
maxsharabayko
added
Type: Maintenance
maxsharabayko
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2503 although this problem was not confirmed in the latest version.
This adds the check if in the non-blocking mode the read-ready epoll flag has NOT been set in case of decryption failure.
Decryption failure is expected with both sides set "relaxed encryption", both have different password settings, and the sender is set a passphrase. In all other cases this should either result in rejected connection or successful reception, and these latter cases read-readiness should be expected (this is checked though through an attempt for reading).