Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Fixed invalid ASSERT checking outdated object in haicrypt #2652

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Feb 7, 2023

Fixes #2651

The ASSERT instruction was using ctx value that was not always equal to crypto->ctx at this time (could be altered in the function called before it).

@ethouris ethouris added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Feb 7, 2023
@maxsharabayko maxsharabayko added this to the v1.5.2 milestone Feb 7, 2023
haicrypt/hcrypt_tx.c Outdated Show resolved Hide resolved
haicrypt/hcrypt_tx.c Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #2652 (9a4e60f) into master (f15f7a2) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   66.45%   66.06%   -0.39%     
==========================================
  Files          99       99              
  Lines       20041    20041              
==========================================
- Hits        13318    13240      -78     
- Misses       6723     6801      +78     
Impacted Files Coverage Δ
haicrypt/hcrypt_tx.c 15.94% <100.00%> (-1.21%) ⬇️
srtcore/list.cpp 80.95% <0.00%> (-6.52%) ⬇️
srtcore/core.h 72.15% <0.00%> (-6.33%) ⬇️
srtcore/core.cpp 60.82% <0.00%> (-0.99%) ⬇️
srtcore/buffer_snd.cpp 68.06% <0.00%> (-0.65%) ⬇️
test/test_bonding.cpp 97.89% <0.00%> (-0.53%) ⬇️
srtcore/congctl.cpp 82.38% <0.00%> (-0.52%) ⬇️
srtcore/utilities.h 63.19% <0.00%> (-0.45%) ⬇️
srtcore/api.cpp 52.75% <0.00%> (-0.11%) ⬇️
srtcore/cache.h 83.07% <0.00%> (+3.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxsharabayko maxsharabayko merged commit 6d774dd into Haivision:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASSERT in HaiCrypt_Tx_ManageKeys upon key refresh
3 participants