[FIX] Changed conditions for setting callbacks #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditions for `srt_listen_callback` and `srt_connect_callback` are that they can only be modified prior to listening or connecting, simultaneously they can be also set to NULL.
ethouris
added
Type: Bug
6 tasks
maxsharabayko
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Please add this new error code (SRT_ECONNSOCK ?) to the srt_listen_callback and srt_connect_callback error codes.
added 2 commits
September 18, 2023 16:36
…back-should-require-pre-or-pre-bind-condition
maxsharabayko
approved these changes
Sep 18, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2683 +/- ##
==========================================
- Coverage 67.05% 66.82% -0.23%
==========================================
Files 102 102
Lines 20277 20280 +3
==========================================
- Hits 13597 13553 -44
- Misses 6680 6727 +47
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
maxsharabayko
deleted the
2635-maint-setting-listener-or-caller-callback-should-require-pre-or-pre-bind-condition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditions for
srt_listen_callbackandsrt_connect_callbackare that they can only be modified prior to listening or connecting, simultaneously they can be also set to NULL.