C examples update

[lars18th]

This it's an upgrade from original PR #21

Take into account that the file examples/make-test-c.sh assumes the structure of examples/include/ and examples/lib/ described in #265.

Regards.

[ethouris]

Why not just a Makefile?

It might be probably even better if this uses the installed version of SRT. For example, instruct the user that they should do:

1. Configure with installation directory of your choice, may be also inside this directory, e.g. "installed": configure --prefix=installed
2. make && make install
3. Compile this pointing the directory in SRTDIR variable: make SRTDIR=../installed
4. Makefile will contain something like:

FLAGS=$(shell PKG_CONFIG_PATH=$(SRTDIR)/lib/pkgconfig pkg-config --cflags --libs srt openssl)

test-c-server: test-c-server.c
test-c-client: test-c-client.c
%:%.c
    $(CC) -o $@ $^ $(FLAGS) -lstdc++

[lars18th]

Hi @ethouris ,

I know about your opinion. And you're right!
However, I think on this examples as a "guide". This it's the reason for a very simple script. So, I suggest to commit in this form (at time).

Regarding the "install" I suggest to support two ways in the "configure": Option 1 it's the "make install". And the Option 2 it's "make package", that generates a target directory with "target/lib", "target/include" and some examples. Why this? For use it for cross-compilation without installing it.

[ethouris]

This is because this can also demonstrate to the users how they can write their applications. In order to have a directory "target" with installed things, it's enough that you simply do configure --prefix=target. Although I think there could be a script that would first compile the SRT library into a directory local to examples and then continues with compiling and linking against it...

[ethouris]

Mind how the user would like to call this application, and whether the stream would be sent from client to server or the other way around. Might be that it would be specified by options, and if not (for simplification) it's rather better that we have a kinda "stream server", so server is sending, client is reading. Important to inform the user that this flag is only needed to communicate with SRT with version earlier than 1.3.0.

[lars18th]

The user doesn't need to call this application. It does "dummy" work. This it's only an "example" code.

[ethouris]

Yes, but you know that users will next try to compile it and see if this works...

[lars18th]

Me too! 😄

[ethouris]

BTW - after my changes with reshaping the project's directories, there's examples/testcapi-connect.c file that is updated with the latest changes. Probably it would be rather a better idea to merge them.

[ethouris]

Come on, I just did this together with some other work. During this "reshaping" I created the examples directory, moved this file to it, and then figured out that it's a complete messup and doesn't work, so I added some fixes. Sorry for that. But still, we need an example with connect and with accept, and without this PR we wouldn't have the latter.

[ethouris]

Hello? We still need this.

[lars18th]

Hello? We still need this.

Hi @ethouris ,

Yes! I'm very busy. I'll review soon.

[maxsharabayko]

• Updated with the latest master
• Replaced deprecated srt_socket(AF_INET, SOCK_DGRAM, 0) with srt_create_socket().
• Fixed sin_family not being set in sockaddr_in.
• Deleted make-test-c.sh if favor of including the samples to CMakeLists.txt.
• Fixed other examples (updated logging -> srt_logging namespace).

Fixes #20. Closes #267.