[core] Fix: In rendezvous when processing resulted in ACCEPT it was still sending rejection #2774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: there was a fix that added sending rejection HS packet back to the peer in case when rendezvous processing ended up in rejection. The condition, however, excluded only
CONN_CONTINUE
value, while besideCONN_REJECT
there was also a possibleCONN_ACCEPT
value returned fromprocessRendezvous
, which would be still handled as it should outside the loop, but this way it was also treated the same as reject.