Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra ack being sent after a connection is established #2832

Merged
merged 8 commits into from
Dec 20, 2023
Merged

Fix extra ack being sent after a connection is established #2832

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
810df90
Fix for bug #2829
yomnes0 Dec 11, 2023
7d4f699
Removed resetBufferWasFull
yomnes0 Dec 11, 2023
0dd0c0c
[docs] Fix SRTO_FC
yomnes0 Dec 11, 2023
4ae4272
Merge branch 'master' of https://github.com/yomnes0/srt
yomnes0 Dec 11, 2023
6fcf98f
[doc]removed change that didn't belong to this PR
yomnes0 Dec 14, 2023
cbf55a2
[core] Moved m_bBufferWasFull initialization to CUDT construct
yomnes0 Dec 18, 2023
bcbda62
Merge branch 'Haivision:master' into master
yomnes0 Dec 18, 2023
c5a7ff9
[core] Removed extra spaces
yomnes0 Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion srtcore/core.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3555,7 +3555,8 @@ void srt::CUDT::startConnect(const sockaddr_any& serv_addr, int32_t forced_isn)
m_iISN = m_ConnReq.m_iISN = forced_isn;

setInitialSndSeq(m_iISN);


yomnes0 marked this conversation as resolved.
Show resolved Hide resolved
m_bBufferWasFull = false; //set BufferWasFull to false to avoid unwarranted acks
// Inform the server my configurations.
CPacket reqpkt;
reqpkt.setControl(UMSG_HANDSHAKE);
Expand Down
1 change: 0 additions & 1 deletion srtcore/core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,6 @@ class CUDT

CallbackHolder<srt_listen_callback_fn> m_cbAcceptHook;
CallbackHolder<srt_connect_callback_fn> m_cbConnectHook;

// FORWARDER
public:
static int installAcceptHook(SRTSOCKET lsn, srt_listen_callback_fn* hook, void* opaq);
Expand Down
Loading