Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing getter for the SRTO_MAXREXMITBW socket option. #2884

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

maxsharabayko
Copy link
Collaborator

  • Added missing getter for the SRTO_MAXREXMITBW socket option.
  • Added unit tests for the SRTO_MAXREXMITBW socket option.

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Feb 20, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b73dbc) 66.99% compared to head (c47a9f2) 48.44%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2884       +/-   ##
===========================================
- Coverage   66.99%   48.44%   -18.55%     
===========================================
  Files         103      141       +38     
  Lines       20460    23307     +2847     
===========================================
- Hits        13707    11292     -2415     
- Misses       6753    12015     +5262     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxsharabayko maxsharabayko merged commit bed5488 into Haivision:master Feb 20, 2024
11 checks passed
@maxsharabayko maxsharabayko deleted the hotfix/get-maxrexmitbw branch February 20, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant