[core] Fixed POST options setting on a connected group. #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
The list of options was unordered, hence the binary search failed to find those options.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2889 +/- ##
==========================================
+ Coverage 64.61% 64.63% +0.02%
==========================================
Files 101 101
Lines 17489 17490 +1
==========================================
+ Hits 11300 11305 +5
+ Misses 6189 6185 -4 ☔ View full report in Codecov by Sentry. |
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Feb 22, 2024
A follow up fix for Haivision#2889.
maxsharabayko
added a commit
that referenced
this pull request
Feb 22, 2024
A follow up fix for #2889.
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 26, 2024
A follow up fix for Haivision#2889.
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 26, 2024
A follow up fix for Haivision#2889.
maxsharabayko
added a commit
that referenced
this pull request
Apr 29, 2024
A follow up fix for #2889.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of options was unordered, hence the binary search failed to find those options. This lead to
srt_setsockoptreturning an error if called on a connected group socket.