Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Improved tests to avoid all-breaking asserts and inter-test messup #2892

Merged

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Feb 27, 2024

  1. Some small refax in api.cpp (shortcut variables, preparing for another change)
  2. Added possibly handling -lognote option and added handling in FileUpload test.
  3. Reworked test_reuseaddr.cpp to use a fixture and a propoer resource management.
  4. Added similar fixes in other tests.

@ethouris ethouris added Type: Maintenance Work required to maintain or clean up the code [tests] Area: Unit tests labels Feb 27, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Feb 27, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 83.41969% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 65.01%. Comparing base (04acbba) to head (ca98ee3).

Files Patch % Lines
test/test_reuseaddr.cpp 84.13% 23 Missing ⚠️
srtcore/api.cpp 50.00% 5 Missing ⚠️
test/test_file_transmission.cpp 80.00% 2 Missing ⚠️
test/test_main.cpp 80.00% 1 Missing ⚠️
test/test_many_connections.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2892      +/-   ##
==========================================
+ Coverage   64.84%   65.01%   +0.16%     
==========================================
  Files         101      101              
  Lines       17536    17544       +8     
==========================================
+ Hits        11372    11407      +35     
+ Misses       6164     6137      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxsharabayko maxsharabayko merged commit 12aad6e into Haivision:master Feb 29, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[tests] Area: Unit tests Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants